Allow user to specify HTTP and gRPC bind addresses (not just ports.) (Rebase of #153)#167
Merged
bboreham merged 3 commits intoweaveworks:masterfrom Nov 3, 2019
ThoreKr:server-listen-addr
Merged
Allow user to specify HTTP and gRPC bind addresses (not just ports.) (Rebase of #153)#167bboreham merged 3 commits intoweaveworks:masterfrom ThoreKr:server-listen-addr
bboreham merged 3 commits intoweaveworks:masterfrom
ThoreKr:server-listen-addr
Conversation
This allows us to use 'localhost' in tests, and prevents an 'Allow connections from...' dialog on MacOS when running unit tests. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
ThoreKr
changed the title
This was referenced Sep 27, 2019
Contributor
Author
|
@bboreham could you please review this pr? |
bboreham
reviewed
Sep 30, 2019
Signed-off-by: Thore Kruess <thore@kruess.xyz>
|
@bboreham what's missing to get this merged? |
Collaborator
|
I think I see two points unresolved. |
Contributor
Author
|
@bboreham and now? |
Collaborator
|
I tell you what, I'll just fix it after. |
yeya24
pushed a commit
to yeya24/common
that referenced
this pull request
Jun 12, 2024
…veworks#167) Signed-off-by: tariqibrahim <tariq181290@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rebase of #153