convert to prometheus/exporter-toolkit#233
Closed
rlankfo wants to merge 4 commits intoweaveworks:masterfrom
Closed
convert to prometheus/exporter-toolkit#233rlankfo wants to merge 4 commits intoweaveworks:masterfrom
rlankfo wants to merge 4 commits intoweaveworks:masterfrom
Conversation
added 2 commits
December 10, 2021 11:18
…er-toolkit/web package
rlankfo
force-pushed
the
upgrade_node_exporter
branch
from
94b4cca to
5daf7d1
Compare
added 2 commits
December 10, 2021 11:48
Author
|
Closing in favor of #230 (didn't see the other PR before opening this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
httpspackage in prometheus/node_exporter has been migrated to prometheus/exporter-toolkit.I'm submitting this change to convert over to the new package so that the version of node_exporter can be updated in the Grafana Agent, and other projects that depend on both node_exporter and weaveworks/common.
Fixes #223
Requires bumping go version to go 1.14