Skip to content

Log request headers, response headers and some body as warning on 500s#59

Merged
jml merged 5 commits intomasterfrom
log-users
Sep 20, 2017
Merged

Log request headers, response headers and some body as warning on 500s#59
jml merged 5 commits intomasterfrom
log-users

Conversation

@jml
Copy link
Contributor

@jml jml commented Sep 20, 2017

Re-do of #41 which was reverted in #56 because I thought it introduced an error that stopped the users service from working. Actually, it was because of #47, which we've fixed with weaveworks/service#1374

This is mostly the same as #41, but

  • only logs 500s
  • fixes a logic bug such that we don't try to log nil headers
  • re-introduces a StatusOK thingummy, so we don't log huge amounts of information on successful requests

@jml jml requested a review from bboreham September 20, 2017 14:24
@jml jml merged commit 955c130 into master Sep 20, 2017
@jml jml deleted the log-users branch September 20, 2017 14:50
jml added a commit to weaveworks/service that referenced this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants