Add notification client library by jpellizzari · Pull Request #62 · weaveworks/common

jpellizzari · 2017-09-22T16:44:45Z

Fixes https://github.com/weaveworks/notification/issues/21

Adds a first iteration of a client library for notifications. This intentionally contains very little abstraction and only be used for an initial non-customer-facing service, such as service-ui-kicker.

notifications/notifications.go

+}
+
+type event struct {
+	Type       string    `json:"type"`


notifications/notifications.go

+
+	eventBytes, err := json.Marshal(e)
+	if err != nil {
+		return errors.Wrapf(err, "Cannot marshal event to []byte %v", msg)


notifications/notifications.go

+// BrowserMessage contains the required fields for formatting browser notifications
+type BrowserMessage struct {
+	Type      string    `json:"type"`
+	Text      string    `json:"text"`


notifications/notifications.go

+
+// SlackMessage contains the required fields for formatting slack messages
+type SlackMessage struct {
+	Text string `json:"text"`


notifications/README.md

+		},
+		Slack: notifications.SlackMessage{
+			Text: markdown,
+		},


notifications/notifications.go

+
+	defer resp.Body.Close()
+
+	if err != nil {


notifications/notifications.go

+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return errors.Wrap(err, "Failed to POST event")
+	}


notifications/notifications.go

+}
+
+// SendEvent sends an event to the notification service.
+func (s *Sender) SendEvent(et string, instance string, t time.Time, msg *Message) error {


notifications/notifications.go

+	Type       string    `json:"type"`
+	InstanceID string    `json:"instance_id"`
+	Timestamp  time.Time `json:"timestamp"`
+	Messages   *Message  `json:"messages"`


notifications/notifications.go

+
+	eventBytes, err := json.Marshal(e)
+	if err != nil {
+		return errors.Wrapf(err, "Cannot marshal event to []byte %s", err)


Migrate ZeroSample and ZeroSamplePair to model

jpellizzari requested review from bboreham, ekimekim and lelenanam September 22, 2017 16:44

jpellizzari force-pushed the notifications branch from 687ef52 to 9a27efb Compare September 22, 2017 16:49

lelenanam reviewed Sep 22, 2017

View reviewed changes

jpellizzari force-pushed the notifications branch from 9a27efb to 17721dd Compare September 22, 2017 17:48

Add notification client library

cfda9dd

jpellizzari force-pushed the notifications branch from 17721dd to cfda9dd Compare September 22, 2017 17:55

jml reviewed Sep 26, 2017

View reviewed changes

notifications/notifications.go

resp, err := http.DefaultClient.Do(req)

if err != nil {

return errors.Wrap(err, "Failed to POST event")

}

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

ekimekim reviewed Sep 26, 2017

View reviewed changes

notifications/notifications.go Outdated

}

// SendEvent sends an event to the notification service.

func (s *Sender) SendEvent(et string, instance string, t time.Time, msg *Message) error {

This comment was marked as abuse.

Sign in to view

bboreham reviewed Sep 27, 2017

View reviewed changes

notifications/notifications.go Outdated

Type string `json:"type"`

InstanceID string `json:"instance_id"`

Timestamp time.Time `json:"timestamp"`

Messages *Message `json:"messages"`

This comment was marked as abuse.

Sign in to view

jpellizzari added 2 commits September 28, 2017 13:37

simplified api

3c5ccf1

Simplified API

c43a738

rndstr reviewed Sep 29, 2017

View reviewed changes

notifications/notifications.go

eventBytes, err := json.Marshal(e)

if err != nil {

return errors.Wrapf(err, "Cannot marshal event to []byte %s", err)

This comment was marked as abuse.

Sign in to view

jpellizzari closed this Oct 4, 2017

yeya24 pushed a commit to yeya24/common that referenced this pull request Jun 12, 2024

Merge pull request weaveworks#62 from prometheus/migrate-zero-values

4757e88

Migrate ZeroSample and ZeroSamplePair to model

Conversation

jpellizzari commented Sep 22, 2017

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants