Add interface to xfer/collector.go, and some more tests#176
Merged
Conversation
Contributor
Author
|
This is another change broken out of #123 |
Member
|
This does more than the description suggests. In particular note the type change for the |
Contributor
|
xfer/collector.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
|
LGTM |
tomwilkie
force-pushed
the
collector-interface
branch
from
686ef26 to
338da0b
Compare
- Add interface to xfer/collector.go - Add some more tests - quit field changed to make it consistent with other Stoppable components in Scope - Add peek, only used for tests
tomwilkie
force-pushed
the
collector-interface
branch
from
338da0b to
06d805d
Compare
Contributor
Author
|
I've updated to account for comments. Will merge when tests pass. |
tomwilkie
added a commit
that referenced
this pull request
Jun 4, 2015
Add interface to xfer/collector.go, and some more tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.