Conversation
Contributor
|
This PR includes both of those, correct? |
Contributor
Author
|
Yes as it depends on them. I won't submit this until they are submitted, so eventually it'll just have one. Conversely, I could rebase this against master and get it in before #178 if that makes it easier for you? |
Contributor
tomwilkie
force-pushed
the
rename-new-report
branch
from
40940ad to
754eac3
Compare
Contributor
Author
|
I've merged #180 already, so here is this off master; no dependancies. |
Contributor
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Jun 5, 2015
Rename NewReport -> MakeReport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #178 & #180