OriginHosts and OriginNodes become Origins#194
Conversation
report/detailed_node.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
How's that look? |
app/detail_pane.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
One last comment; otherwise LGTM Is coveralls being weird or did it really drop by 6%? That might be worth investigating. |
|
Also squash pls! |
Coveralls has been being weird all day, but it wouldn't surprise me if coverage has dropped — there are a lot of tests that I'm waiting to port from #123, because they rely on features that haven't yet been moved over, and I'd rather do it all in one motion than waste time on getting them working in the intermediate steps and then blowing it away. At the end of all of this, I'll promise a significant increase in test coverage, probably double-digit. |
Another baby step towards #123, this change follows from #192 and merges the two concepts of Origin in a renderable node. We also cut out a layer of abstraction, and add an OriginTable method to Report, which directly generates a table of info for the detail pane given any origin node ID. Other changes from feedback: - Assume origin IDs are unique and don't reflect.Dedupe - Improve origin ID lookup - Move OriginTable to detailed_node.go, as a free function - rm app/detail_pane.go (empty)
|
SGTM! |
OriginHosts and OriginNodes become Origins
2 participants
Another baby step towards #123, this change follows from #192 and merges the two concepts of Origin in a renderable node. We also cut out a layer of abstraction, and add an OriginTable method to Report, which directly generates a table of info for the detail pane given any origin node ID.