First pass at integration tests#273
Conversation
paulbellamy
force-pushed
the
integration-tests
branch
2 times, most recently
from
effb291 to
e4d63e2
Compare
|
|
this will break scheduling as its not namespaced per repo. Could either disable it, namespace it, or add prefix to all the tests. |
integration/setup.sh
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
integration-tests
branch
2 times, most recently
from
65b8f3f to
04da157
Compare
|
Won't running these on PRs have the same issue as on the weave repo (exposing gce credentials)? |
paulbellamy
force-pushed
the
integration-tests
branch
3 times, most recently
from
6565e79 to
a6e745a
Compare
|
It won't expose the keys if you put them in a variable in the circle ui (as opposed to checked in). This is how we do it on weave. And Peter & David push to branched on weaveworks/scope, so the tests will run fine there. |
paulbellamy
force-pushed
the
integration-tests
branch
5 times, most recently
from
9992f19 to
dde9a40
Compare
|
Just has one basic test for now. Needs more added... Will skip integration tests on forked PRs (i.e. if there is no $SECRET_PASSWORD), but will run them on main-repo PRs. |
|
@tomwilkie could you please review the weave side of things, while doing this. It will need to be in a release before this will work. We could point the integration tests at weave/master until that point. |
paulbellamy
force-pushed
the
integration-tests
branch
5 times, most recently
from
111fcb8 to
6f94001
Compare
Integration tests are only run on circle. They checkout the weave project, and use test helpers from there. There are just a few basic tests for now, to confirm it works.
paulbellamy
force-pushed
the
integration-tests
branch
from
7c34148 to
c92773f
Compare
paulbellamy
changed the title
circle.yml
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
1 comment otherwise LGTM |
check before each integration test line is a bit ugly. Can combine them into one step, but then you don't get metrics on how long each step takes (in circle).
First pass at integration tests
2 participants
Will fix #79.
Just adds a basic test for now. If people like this approach, I'll add another couple tests to this PR.
Depends on these changes being merged first, into the weave repo.
The
setup.shscript in here willgo get github.com/weaveworks/weave, for our working copy, and uses a few of the test helpers from there, to avoid duplicating. We considered having a separate repo for the integration test helpers, but didn't want to manage another repo.Having separate vagrant files in here is a bit messy, potentially, so am open to suggestions on that, also.
Also, need to set these up to run on circle.