Improve feedback to user when objects aren't retrieved due to RBAC #3667
Merged
Improve feedback to user when objects aren't retrieved due to RBAC #3667
Conversation
AlinaGoaga
changed the title
…ops into rbac-error-feedback
Contributor
|
@foot Another one for you when you get back :-) |
foot
reviewed
Aug 4, 2023
Contributor
|
Tests are hanging 🤔 |
…ops into rbac-error-feedback
- This can be diff for diff types (shouldn't but can), so now report all the different namespaces by kind too - Fixes "no data" rowSpan if there is a checkbox col. - Connect up Sources page - Simplify type returned from the BE so it can be used without transforming it on the FE
foot
approved these changes
Aug 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2427
What changed?
We're doing a pilot on the Application table to display an info note containing the clusters and namespaces that have been searched to retrieved the data.
Why was this change made?
Sometimes users don't understand why they cannot see certain objects in the UI. This can be caused by a lack of permissions. We're looking to include more information on which clusters and namespaces have been searched trying to retrieve objects for a specific page.
How was this change implemented?
ListObjectsnow returns in addition to the Objects and associated Errors, a list of searched Namespaces (including cluster name and an array of namespaces per cluster)