Suspend/resume/reconcile Image Repositories#3831
Merged
Conversation
opudrovs
changed the title
opudrovs
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
4 times, most recently
from
3b9c2c2 to
b5a9403
Compare
joshri
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
from
b5a9403 to
71c7056
Compare
opudrovs
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
11 times, most recently
from
08e33df to
306b0d8
Compare
…mageUpdateAutomations` to `wego-admin-cluster-role`.
…y` as a client object.
…mageRepositories table.
…add img repo sync test
…rce details pages with the SyncActions component. Add SyncActions component on the Image Repository Details page.
yiannistri
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
from
564a74b to
f7198f3
Compare
yiannistri
reviewed
Jul 25, 2023
Contributor
yiannistri
left a comment
yiannistri
left a comment
There was a problem hiding this comment.
Backend code looks fine 👌 @joshri can you please review the UI part?
chanwit
added
type/enhancement
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3820
Closes #3821
Added explicit permissions for
ImagePolicies,ImageRepositories,ImageUpdateAutomationstowego-admin-cluster-role.Added
ImageRepositoryAdapterto makeImageRepositoriesreconcilable in the UI.Registered the
ImageRepositoryKind to be able to getImageRepositoryas a client object.Enabled Sync, Suspend, and Resume buttons and checkboxes for the ImageRepositories table.
Added the ImageRepository CRD.
Added the SyncActions component with snapshot tests.
Added the SyncActions component on the Image Repository Details page.
Replaced Sync and Suspend/Resume UI elements on the Automation and Source details pages with the SyncActions component.