Skip to content

Fix error when syncing HelmChart#3873

Merged
yiannistri merged 4 commits intomainfrom
3852-fix-error-when-syncing-helmchart
Jul 25, 2023
Merged

Fix error when syncing HelmChart#3873
yiannistri merged 4 commits intomainfrom
3852-fix-error-when-syncing-helmchart

Conversation

@opudrovs
Copy link
Copy Markdown
Contributor

@opudrovs opudrovs commented Jul 21, 2023

Closes #3852

  • Added HelmChart to known object Kinds when getting Flux objects for syncing.

  • Added missing sync tests to cover all source objects.

  • Reordered tests for consistency (automations first, then sources).

@opudrovs opudrovs added the area/ui Issues that require front-end work label Jul 21, 2023
@opudrovs opudrovs force-pushed the 3852-fix-error-when-syncing-helmchart branch 2 times, most recently from a5028f8 to 4b076ff Compare July 21, 2023 13:14
@opudrovs opudrovs force-pushed the 3852-fix-error-when-syncing-helmchart branch from ae7f61c to a5a385f Compare July 24, 2023 21:55
@opudrovs opudrovs marked this pull request as ready for review July 24, 2023 23:26
@opudrovs opudrovs requested review from joshri and yiannistri July 24, 2023 23:26
Copy link
Copy Markdown
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👌

@yiannistri yiannistri enabled auto-merge (rebase) July 25, 2023 08:51
@yiannistri yiannistri merged commit 28e4418 into main Jul 25, 2023
@yiannistri yiannistri deleted the 3852-fix-error-when-syncing-helmchart branch July 25, 2023 08:56
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui Issues that require front-end work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error when syncing HelmChart

2 participants