Remove Flux version from /v1/version response and page footers#3876
Merged
Remove Flux version from /v1/version response and page footers#3876
Conversation
makkes
force-pushed
the
drop-flux-version
branch
2 times, most recently
from
649a750 to
2943b10
Compare
The Flux version has been displayed in two locations of the UI: In the footer of every page and on the "Flux Runtime" page. To display the Flux version in these locations, two different ways to retrieve said version have been implemented: 1. On the "Flux Runtime" page the version is retrieved from the Flux deployment objects for each cluster WeGO knows about. 2. In the footer the version is retrieved from the /v1/version endpoint which in turn tries to find the Flux namespace on the cluster that it runs on. In order to properly display the Flux version properly, the UI user would have to be allowed to list (1) Namespaces on the management cluster and (2) Flux deployments on all clusters including the management cluster. This leads to situations where one of these two permissions is not set and the user will see a Flux version properly rendered in one location but not the other which is potentially confusing. In order to improve the user experience, this change completely drops the rendering of the Flux version in the footer so that there is only one consistent method to fetch the Flux version. Users that aren't allowed to list the Flux runtime information will not be able to find out the Flux version, anyway, so for those users rendering an "-" in the footer doesn't provide any information. All others can refer to the "Flux Runtime" page and will see all Flux versions on all clusters together with additional runtime information. closes #3665
makkes
force-pushed
the
drop-flux-version
branch
from
2943b10 to
0f8523f
Compare
bigkevmcd
approved these changes
Jul 24, 2023
Contributor
bigkevmcd
left a comment
bigkevmcd
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this.
luizbafilho
approved these changes
Jul 24, 2023
Member
Author
|
@bigkevmcd @luizbafilho can one of you merge this for me, please? I don't have permission. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flux version has been displayed in two locations of the UI: In the footer of every page and on the "Flux Runtime" page. To display the Flux version in these locations, two different ways to retrieve said version have been implemented:
In order to properly display the Flux version properly, the UI user would have to be allowed to list (1) Namespaces on the management cluster and (2) Flux deployments on all clusters including the management cluster.
This leads to situations where one of these two permissions is not set and the user will see a Flux version properly rendered in one location but not the other which is potentially confusing.
In order to improve the user experience, this change completely drops the rendering of the Flux version in the footer so that there is only one consistent method to fetch the Flux version. Users that aren't allowed to list the Flux runtime information will not be able to find out the Flux version, anyway, so for those users rendering an "-" in the footer doesn't provide any information. All others can refer to the "Flux Runtime" page and will see all Flux versions on all clusters together with additional runtime information.
closes #3665