Skip to content

Add sync and suspend for image update automations#3885

Merged
yiannistri merged 4 commits intomainfrom
sync-img-update-automation
Jul 27, 2023
Merged

Add sync and suspend for image update automations#3885
yiannistri merged 4 commits intomainfrom
sync-img-update-automation

Conversation

@joshri
Copy link
Copy Markdown
Contributor

@joshri joshri commented Jul 25, 2023

Allows sync and suspend for image update automations + fixes a bug where buttons were not disabled when un-checking the last checked button (having variable outside of useEffect prevented update -> see CheckboxActions component)

Screen.Recording.2023-07-25.at.1.17.27.PM.mov

@joshri joshri added the area/ui Issues that require front-end work label Jul 25, 2023
Copy link
Copy Markdown
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the 'Sync without source' option, as for image update automation resources, there is no source to reconcile anyway. For example, in the changes we've done recently for image repositories (which also have no associated source), we used the 'Sync' option only.

Sidenote: It's somewhat confusing that the options we present in the UI are the opposite of what the Flux CLI uses. As an example, the following command is used to reconcile a resource without also reconciling its source:

# Trigger a Kustomization apply outside of the reconciliation interval
flux reconcile kustomization podinfo

The following command reconciles the resource with its source:

# Trigger a sync of the Kustomization's source and apply changes
flux reconcile kustomization podinfo --with-source

In my opinion, the UI should match the Flux CLI to avoid possible user confusion. By the way this is just a suggestion and can be addressed separately as it's unrelated to the changes of this PR.

joshri added 2 commits July 26, 2023 11:54
…g with an additional ui change to checkbox actions that re-disables buttons when removing all checked items
@joshri joshri force-pushed the sync-img-update-automation branch from 36521cb to 704b093 Compare July 26, 2023 15:54
@joshri
Copy link
Copy Markdown
Contributor Author

joshri commented Jul 26, 2023

@yiannistri

Removed source sync for image update automations:
image
image

Default sync behavior will be addressed in a separate PR as discussed in standup 🌞

@yiannistri yiannistri enabled auto-merge (rebase) July 27, 2023 10:38
Copy link
Copy Markdown
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yiannistri yiannistri merged commit d65045d into main Jul 27, 2023
@yiannistri yiannistri deleted the sync-img-update-automation branch July 27, 2023 10:39
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui Issues that require front-end work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants