Conversation
4095c77 to
f43053d
Compare
5 tasks
f67457f to
1f07b53
Compare
1f07b53 to
41f829c
Compare
added 2 commits
July 27, 2023 19:27
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
41f829c to
3d62723
Compare
enekofb
reviewed
Jul 28, 2023
Contributor
There was a problem hiding this comment.
fantastic work.
some follow up topics before approving:
- verify
gitops run - understand experience for not v2 users (using with flux v0.4x) -> done here
- verify cli
and a couple of follow-up tickets
- to prepare release notes and update documentation https://docs.gitops.weave.works/docs/guides/fluxga-upgrade/
- to potentially implement multiple kind versions querying
Contributor
Co-authored-by: Eneko Fernández <12957664+enekofb@users.noreply.github.com>
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
6a9f996 to
c313cdc
Compare
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
c313cdc to
52eefe8
Compare
Contributor
|
🟢 quick test cli works in PR |
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #3878
See the counter part #3880 which uses controller runtime v0.15
Notable differences: