Merged
Conversation
enekofb
reviewed
Aug 1, 2023
Contributor
enekofb
left a comment
There was a problem hiding this comment.
we could add a test case here for the scenario we are trying to handle
apiVersion: kustomize.toolkit.fluxcd.io/v1
kind: Kustomization
metadata:
creationTimestamp: "2023-07-31T15:05:53Z"
finalizers:
- finalizers.fluxcd.io
generation: 1
labels:
kustomize.toolkit.fluxcd.io/name: flux-system
kustomize.toolkit.fluxcd.io/namespace: flux-system
name: rbac-secrets-good-practices
namespace: flux-system
resourceVersion: "9437086"
uid: f3780853-bf47-4a3b-b5e3-f029623e8595
spec:
force: false
interval: 1m0s
path: ./goodpractices/kubernetes/rbac/secrets
prune: true
sourceRef:
kind: GitRepository
name: policy-library
status:
conditions:
- lastTransitionTime: "2023-07-31T15:05:54Z"
message: Source is not ready, artifact not found
observedGeneration: 1
reason: ArtifactFailed
status: "False"
type: Ready
observedGeneration: -1added the example also to the ticket
94ffd18 to
722588d
Compare
enekofb
approved these changes
Aug 1, 2023
bigkevmcd
requested changes
Aug 2, 2023
Contributor
|
@chanwit are you going to address these issues? if not, I'll happily close this and open a new PR to do it. |
Member
Author
|
I'll continue this week. Sorry I am currently having a technical issue with my box. |
0a55e7f to
9272e69
Compare
bigkevmcd
approved these changes
Aug 22, 2023
added 4 commits
August 22, 2023 20:13
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
2a69344 to
fbd0974
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3902