Skip to content

Docs changes in WGE install guide, cluster mgmt pages#3919

Closed
lasomethingsomething wants to merge 38 commits intomainfrom
docs-changes-aug7
Closed

Docs changes in WGE install guide, cluster mgmt pages#3919
lasomethingsomething wants to merge 38 commits intomainfrom
docs-changes-aug7

Conversation

@lasomethingsomething
Copy link
Copy Markdown
Contributor

@lasomethingsomething lasomethingsomething commented Aug 7, 2023

Closes

What changed?

Folds a number of pages into the install WGE guide for user discovery. Addresses link changes in current and v0.29.0 versions. Addresses feedback from CX and Engineering related to missing or inaccurate information in some cluster mgmt pages.

Why was this change made?

To fix errors, gaps, and other docs issues

How was this change implemented?

Substantial changes triggered by feedback from Sales and other internal parties about issues using the user docs. Gets rid of the current "Access Configuration" section in order to fold pages and content into the installation guide where users are more likely to expect and seek them.

How did you validate the change?

Ran npm run build to fix broken links

Release notes

Fixes errors and gaps in release guide Cluster Management and WGE Install guide

Documentation Changes

The PR is a doc change

@lasomethingsomething lasomethingsomething self-assigned this Aug 7, 2023
@lasomethingsomething lasomethingsomething added user-guide Improvements to docs at https://docs.gitops.weave.works/ documentation Improvements or additions to documentation labels Aug 7, 2023
@makkes makkes mentioned this pull request Aug 8, 2023
@lasomethingsomething
Copy link
Copy Markdown
Contributor Author

lasomethingsomething commented Aug 9, 2023

Partly fixes #3886

@enekofb
Copy link
Copy Markdown
Contributor

enekofb commented Aug 15, 2023

@LappleApple why the PR does not uses the PR template ?

I find it useful in particular for reviewers to frame the change:

For example, in PR description says

Folds a number of pages into the install WGE guide for user discovery.

But does no provides context on the current issue of user discovery and how this enhances that situation.

@lasomethingsomething
Copy link
Copy Markdown
Contributor Author

@enekofb Addressed comment

Copy link
Copy Markdown
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that CI docs job fails

Tried to run it locally with the same issue

➜  website git:(docs-changes-aug7) GA_KEY=fakekey yarn start                                                                                                                                                                                                                                                                                    
[INFO] Starting the development server...
[ERROR] Loading of version failed for version current
[ERROR] Error: Invalid sidebar file at "sidebars.js".

You could follow dev docs instructions to test it in your environment

@lasomethingsomething
Copy link
Copy Markdown
Contributor Author

@enekofb I typically do that, and did so before filing this, but we've made changes since then. I'll run again tomorrow.

@lasomethingsomething lasomethingsomething marked this pull request as draft August 17, 2023 12:30
@lasomethingsomething
Copy link
Copy Markdown
Contributor Author

Closing in favor of #3955.

@lasomethingsomething lasomethingsomething deleted the docs-changes-aug7 branch August 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation user-guide Improvements to docs at https://docs.gitops.weave.works/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants