Add batch error handling to Notifications page#3933
Merged
jpellizzari merged 2 commits intomainfrom Aug 10, 2023
Merged
Conversation
Contributor
Author
joshri
approved these changes
Aug 9, 2023
Contributor
joshri
left a comment
There was a problem hiding this comment.
LGTM - might be worth distinguishing between the request errors and permissions errors somehow...maybe permissions errors are more like warnings? Just a thought for the future
Contributor
Author
I think "errors is errors" as far as the backend is concerned. It doesn't differentiate between permissions and request errors. |
Before this change, if you got lots of errors on the Notification page, they would all stack up and take the entire page height. After, they will be organized in a navigable list, like how it done in Enterprise.
3912703 to
013177b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #3634
Adds an
ErrorListcomponent to Core, heavily inspired by the one used in EE. This also exports theErrorListcomponent so that it may be imported in EE and eventually subsume theAlertListErrorscomponent (there is nothing wrong with that component currently, but this will enforce Consistency:tm:).There are now two error "classes" on the page:
Error when we can't reach the backend:

Batched errors from various clusters (backend returns lots of errors):

Simulated the error state using this: