Set static height on signin footer#3944
Merged
jpellizzari merged 1 commit intomainfrom Aug 16, 2023
Merged
Conversation
enekofb
force-pushed
the
3210-signin-dark
branch
from
6ebf4de to
541b63b
Compare
Contributor
|
Btw, i rebased the PR to validate the behaviour of the release locking PR in case there was an issue to fix it with less impact possible to us. It worked as you could see from the checks. Thanks you! |
jpellizzari
force-pushed
the
3210-signin-dark
branch
from
541b63b to
df9d43e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3210
Sets a static height on the footer to ignore the "wheel" image height. I chose
300pxbecause it was roughly what both images were resolving to naturally.