Conversation
foot
commented
Aug 21, 2023
foot
commented
Aug 21, 2023
foot
commented
Aug 21, 2023
foot
commented
Aug 22, 2023
bigkevmcd
requested changes
Aug 22, 2023
Contributor
Author
|
cc @LappleApple as you've been looking at the user-guide. This PR also adds some user-guide docs about this new anonymous access feature. |
bigkevmcd
approved these changes
Aug 22, 2023
Contributor
|
Thanks! |
- So that the NewAnonymousPrincipalGetter is created correctly
- And correctly test if userInfo has returned a valid principal
- Add some more tests
- UI is now responsible for locking etc,
This reverts commit a453ea0.
- Improve init loggin - Docstrings - Clarify user-guide phrasing around feature design
This is not the case
- There is some work going on to refactor those pages and so the changes will be added there instead
This was referenced Aug 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Introduces a cli-flag to enable "anonymous" mode.
This allows the dashboard to be configured without auth, no login screen will be shown. Its designed to be used with external authentication systems like auth-proxies.
The kubernetes
Userthat is impersonated can be configured via the flag value.Why was this change made?
Allows external auth systems to be used instead of built in OIDC.
How was this change implemented?
How did you validate the change?
Documentation Changes
Yes, included.