Skip to content

dashboard helmrepository apiVersion should be v1beta2 not v1#3959

Merged
enekofb merged 1 commit intomainfrom
issues/3957
Aug 22, 2023
Merged

dashboard helmrepository apiVersion should be v1beta2 not v1#3959
enekofb merged 1 commit intomainfrom
issues/3957

Conversation

@enekofb
Copy link
Copy Markdown
Contributor

@enekofb enekofb commented Aug 22, 2023

Closes #3957

What changed?

Changes generated dashboard helmrepository apiVersion from v1 to v1beta2

Why was this change made?

HelmRepository still not yet in v1 so creating in v1 will end in the resource not been created

How did you validate the change?

  • Adjusted unit test expectation
  • Executed the command too

Release notes
No

Documentation Changes
No

@enekofb enekofb requested review from chanwit and yiannistri August 22, 2023 08:34
Copy link
Copy Markdown
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Copy Markdown
Member

@chanwit chanwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @enekofb
LGTM

@enekofb enekofb merged commit 9808968 into main Aug 22, 2023
@enekofb enekofb deleted the issues/3957 branch August 22, 2023 09:04
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps create dashboard export error

3 participants