releasing container image before github release#3971
Merged
Conversation
enekofb
force-pushed
the
issues/3945
branch
3 times, most recently
from
1d18b77 to
1e4dc4c
Compare
enekofb
changed the title
enekofb
requested review from
bigkevmcd,
chanwit,
foot,
jpellizzari,
squaremo,
waleedhammam and
yiannistri
enekofb
force-pushed
the
issues/3945
branch
2 times, most recently
from
c8ae11b to
055aa32
Compare
waleedhammam
approved these changes
Sep 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3945
What changed?
Changed release ordering to dont publish Github release before container image
Why was this change made?
To flag the release is available closer to the time where the artifacts are ready. See ADR for existing limitations.
How was this change implemented?
Making goreleaser to depend on artifacts build jobs
How did you validate the change?
workflow running:
https://github.com/enekofb/weave-gitops/actions/runs/6034814890
https://github.com/enekofb/weave-gitops/actions/runs/6034814890/job/16373954465
and release created after image was built
Release notes
Not required
Documentation Changes
Not required