Conversation
joshri
force-pushed
the
get-object-verified-source
branch
from
b846798 to
9833969
Compare
| export const VerifiedStatus = ({ | ||
| const checkVerifiable = (sourceRef: ObjectRef): boolean => { | ||
| const { name, namespace, kind } = sourceRef; | ||
| //can sourceRef actually return undefined stuff?! Typescript says it can. |
There was a problem hiding this comment.
Yup just double checking in objects.ts and it looks like it's defined as sourceRef(): ObjectRef | undefined
| kind = "", | ||
| clusterName = "", | ||
| } = sourceRef || {}; | ||
| const { data: verifiable } = useGetObject<VerifiableSource>( |
There was a problem hiding this comment.
Maybe I'd leave this as { data: source } and just send it as source={source} like you did above also for consistency?
There was a problem hiding this comment.
This actually causes a duplicate identifier error but I wish it didn't!
|
Hey Josh, this looks good to me! It's code moved from Backstage, should probably look into something similar there but we'll leave that for later 🤔 I think the |
Ah I see - I switched it up so that I could just pass any source down to the component and then verify it later - if we change it to |
* modify hook on verified status check * extra variable * remove export into SourcesTable * refactoring to one component * edit comment explaining verification check
* modify hook on verified status check * extra variable * remove export into SourcesTable * refactoring to one component * edit comment explaining verification check
* Modify hook on verified status check (#3974) * modify hook on verified status check * extra variable * remove export into SourcesTable * refactoring to one component * edit comment explaining verification check * Move stray Progressive Delivery text to related page (#3923) * Move stray PD text to related page * Update progressive-delivery-flagger-install.mdx Update link * Update website/docs/progressive-delivery/progressive-delivery-flagger-install.mdx Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com> * Updates Delivery dashboard * Replaces !'s with dashes * Adds necessary yaml for UI login * Adds line in intro page about browser support * Adds line breaks attempt number two * Fixing the line breaks round three * Fixing icons * Update website/docs/progressive-delivery/progressive-delivery-flagger-install.mdx Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com> --------- Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com> * update tabs view * update hight * fix font weight * remove unused imports * update tab border --------- Co-authored-by: Joshua Israel <65822698+joshri@users.noreply.github.com> Co-authored-by: Lauri Apple <lauri@weave.works> Co-authored-by: Yiannis <8741709+yiannistri@users.noreply.github.com> Co-authored-by: Casper <ahmed.shabaan@weave.works>
2 participants
I was asked about what the
verifiedcolumn meant on the automations table, and I noticed a potential improvement where we wouldn't have to filter through all the sources every time we display the status, and instead just request the object we need directly (and only running the request if it's a Git repo or OCI repo in the first place). Is this a thing?