fix inconsistency in listing components#3984
Merged
TheGostKasper merged 11 commits intomainfrom Sep 6, 2023
Merged
Conversation
…o 3898-inconsistency-in-list-components
jpellizzari
approved these changes
Sep 5, 2023
Contributor
jpellizzari
left a comment
jpellizzari
left a comment
There was a problem hiding this comment.
Code LGTM. Please update the PR description to read like a release note 👍
joshri
reviewed
Sep 5, 2023
|
|
||
| const LabelFlex = styled(Flex)` | ||
| padding: ${(props) => props.theme.spacing.xxs} 0; | ||
| overflow-x: scroll; |
Contributor
There was a problem hiding this comment.
Does the component still scroll on overflow after removing this?
Contributor
Author
There was a problem hiding this comment.
I use wrap with Flex so whenever it's overflowing it'll be displayed in multiple lines
joshri
approved these changes
Sep 6, 2023
Contributor
joshri
left a comment
joshri
left a comment
There was a problem hiding this comment.
Yep - I see now that you added wrap to the Labels - thanks!
TheGostKasper
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3898
What changed?
#3898 (comment)
Why was this change made?
Throughout the different functionalities of the Demo we have different ways of organizing the information in lists.
From my point of view, the options with two columns are clearer. I would leave it as the standard component but reduce the spacing between columns.
redirect3-2023-09-03_14.08.21.mp4