Skip to content

fix Space in between buttons#3985

Merged
AsmaaNabilBakr merged 3 commits intomainfrom
adjust-spacing
Sep 6, 2023
Merged

fix Space in between buttons#3985
AsmaaNabilBakr merged 3 commits intomainfrom
adjust-spacing

Conversation

@AsmaaNabilBakr
Copy link
Copy Markdown
Contributor

@AsmaaNabilBakr AsmaaNabilBakr commented Sep 4, 2023

Closes #3891

What changed?
Set a fixed space between buttons to be 12px

before:
image
after:
image

before:
image
after:
image

before:
image
after:
image

before:
image
after:
image

@AsmaaNabilBakr AsmaaNabilBakr added the area/ui Issues that require front-end work label Sep 4, 2023
@AsmaaNabilBakr
Copy link
Copy Markdown
Contributor Author

AsmaaNabilBakr commented Sep 4, 2023

@jpellizzari FYI, @TheGostKasper suggest another solution for #3891 so I create this PR to try and it works by:

  • using Flex component and gap property in EE.
  • remove Spacer and update gap in some components in OSS.
    instead of over right on styles in OSS.

EE PR : #3279

@AsmaaNabilBakr AsmaaNabilBakr marked this pull request as ready for review September 4, 2023 20:10
@AsmaaNabilBakr AsmaaNabilBakr self-assigned this Sep 4, 2023
@AsmaaNabilBakr AsmaaNabilBakr changed the title fix spaces fix Space in between buttons Sep 4, 2023
@AsmaaNabilBakr AsmaaNabilBakr merged commit 83110e5 into main Sep 6, 2023
@AsmaaNabilBakr AsmaaNabilBakr deleted the adjust-spacing branch September 6, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui Issues that require front-end work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space in between buttons and weird black line

3 participants