Fix the error could not not resolve module "node:os" from cosmiconfig preventing to build the UI

[opudrovs]

Closes #3986

Fixes the following error preventing to build the UI:

[go-build 13/13] RUN --mount=type=cache,target=/root/.cache/go-build LDFLAGS=${LDFLAGS##-X localbuild=true} GIT_COMMIT=$GIT_COMMIT make gitops-server [cached]
       → yarn build
       → yarn run v1.22.19
       → warning package.json: No license field
       → $ parcel build --target default
       → Building...
       → Bundling...
       → Packaging & Optimizing...
       → 🚨 Build failed.
       → 
       → @parcel/optimizer-htmlnano: Could not resolve module "node:os" from 
       → "/home/app/node_modules/cosmiconfig/dist/index.js"
       → 
       → 
       →   Error: Could not resolve module "node:os" from 
       →   "/home/app/node_modules/cosmiconfig/dist/index.js"
       →       at NodePackageManager.resolveInternal 
       →   (/home/app/node_modules/@parcel/package-manager/lib/index.js:3672:21)
       →       at NodePackageManager.resolveSync 
       →   (/home/app/node_modules/@parcel/package-manager/lib/index.js:3567:29)
       →       at NodePackageManager.requireSync 
       →   (/home/app/node_modules/@parcel/package-manager/lib/index.js:3394:33)
       →       at Module.m.require 
       →   (/home/app/node_modules/@parcel/package-manager/lib/index.js:3410:25)
       →       at require (node:internal/modules/cjs/helpers:119:18)
       →       at Object.<anonymous> 
       →   (/home/app/node_modules/cosmiconfig/dist/index.js:23:35)
       →       at Module._compile (node:internal/modules/cjs/loader:1198:14)
       →       at Object.Module._extensions..js 
       →   (node:internal/modules/cjs/loader:1252:10)
       →       at Module.load (node:internal/modules/cjs/loader:1076:32)
       →       at NodePackageManager.load 
       →   (/home/app/node_modules/@parcel/package-manager/lib/index.js:3423:15)
       → info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
       → error Command failed with exit code 1.
       → make: *** [Makefile:165: ui] Error 1
     
     ERROR IN: [ui 12/12] RUN --mount=type=cache,target=/home/app/ui/.parcel-cache make ui

Build Failed: ImageBuild: executor failed running [/bin/sh -c make ui]: exit code: 2

based on a suggestion from the following issue:
parcel-bundler/parcel#9224

[foot]

Don't think we need it here, the website (docusaurus) doesn't seem to use htmlnano

[opudrovs]

Thanks, good point, will remove it and test the docs.

[foot]

Does running yarn locally give some changes to the yarn.lock we should add too?

[opudrovs]

Will add it, the PR is not up for review yet, I was just testing the main fix. Will submit it for review tomorrow.

[opudrovs]

Updated yarn.lock. To the final testing now.

[foot]

• Can only repro w/ tilt up
• Not with any combination of rm -rf node_modules / make node_modules etc locally on MacOS
• Fix here works!

Nice one!

[opudrovs]

@foot thanks for reproducing the error and checking the fix! It's great that it works as expected. I am polishing the PR now and will raise it probably even today.

[opudrovs]

Tested the app locally with Tilt and also with yarn start in addition to Tilt, it works fine for me with the fix.

Also confirmed that the website does not need this fix indeed.

[jpellizzari]

@opudrovs Any idea what htmlnano and cosmicconfig are used for? A require("node:os") means it is looking for a newer version of node.

I'm not familiar with either of these packages.

[opudrovs]

@jpellizzari it looks like htmlnano and cosmiconfig are Parcel's subdependencies, they are not imported by the project directly:

olga@MacBook-Pro weave-gitops % npm list htmlnano
@weaveworks/weave-gitops@0.31.2 /Volumes/Macintosh_HD_Data/_job_ww/_src/weave-gitops
└─┬ @parcel/config-default@2.8.3
  └─┬ @parcel/optimizer-htmlnano@2.8.3
    └── htmlnano@2.0.3

olga@MacBook-Pro weave-gitops % npm list cosmiconfig 
@weaveworks/weave-gitops@0.31.2 /Volumes/Macintosh_HD_Data/_job_ww/_src/weave-gitops
└─┬ @parcel/config-default@2.8.3
  └─┬ @parcel/optimizer-htmlnano@2.8.3
    └─┬ htmlnano@2.0.3
      └── cosmiconfig@7.1.0