Add helm 'values' flags to create dashboard#3990
Merged
yiannistri merged 5 commits intoweaveworks:mainfrom Oct 17, 2023
Merged
Conversation
Contributor
Author
|
Hi, sorry i drop this PR from nowhere. I was playing with the |
6b79eb4 to
5c82a07
Compare
Contributor
|
@laupse thank you for sending this PR, the new CLI flag is a useful addition 👍 I took the liberty of editing your PR slightly and I have now asked for another review. But I think it should be good to merge soon. |
Add helm 'values' flags to create dashboard weaveworks#2
fbdafe7 to
80c8a10
Compare
Merged
Contributor
Author
|
Thank you for taking time considering and merging this PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
flags
--valuesadded tocreate dashboardandbeta runso we can provide additional helm values when generating HelmRelease from thegitopscliWhy was this change made?
Didn't wanted to have to deal with editing the yaml HelmRelease file to add values
How was this change implemented?
This is has been inspired by how it is implemented in flux for creating HelmRelease
How did you validate the change?
with this yaml
we have this export from the below command
Release notes
N/A
Documentation Changes
cli is self documented