Conversation
- Allows us to support a wider range of ingress-controllers
db0a707 to
bac6af6
Compare
- golang gocritic linting
|
@LappleApple I'll write up some docs for this. "How to run weave-gitops on a sub path of your ingress controller", thoughts about where it should go? |
bigkevmcd
left a comment
There was a problem hiding this comment.
We should document how to do this?
|
Looks good, but we probably need some Helm and documentation! |
Co-authored-by: Kevin McDermott <kevin@weave.works>
jpellizzari
left a comment
There was a problem hiding this comment.
Nice work! Love the UI tests and extra helper script.
|
@foot Let's chat next week about docs-y things :) |
bigkevmcd
left a comment
There was a problem hiding this comment.
Tested it locally, and it works, let's get the exported functions either not-exported, if they don't need to be, or documented.
Otherwise, looks good.
- Helps the user find what they are after
The UI is built w/ relative asset links. If you land on a subpage e.g. /git-repo/details, then the base tag must still be present to indicate the relative js/css should be loaded from "/" and not from "/git-repo/details"
- Add Makefile helper too
|
@foot Still misses a new proper image and an updated Helm chart to reference that image to be usable by end users if not mistaken? Anyhow, thank you for this - in my view - important feature! |
|
@gre9ory it should be in the next release |
Fixes #2529
What changed?
Why was this change made?
How was this change implemented?
UI routing now checks for and respects a
<base href="/foo/" />tag if present.If its not present everything works as it did before.
Understand
<BrowserRouter />.<base href="/wego/" />tells the UI where to fetch relative resources from and where the api request can be made from (/wego/v1/api etc)On the backend
How to set the
<base />tag in the served index.html<base />tag injected from cli/302 ->/weave-gitopsHow did you validate the change?
Test
additionalArgsintools/helm-dev-values.yamltilt upTest to check ingress works too..
Spin up a kind cluster w/ ingress support:
./tools/kind-with-ingress.shingressandadditionalArgssections intools/helm-dev-values.yamltilt upRelease notes
Documentation Changes