Conversation
a48c0a0 to
993905a
Compare
Contributor
|
@joshri How does this compare to the Reference: https://dev.to/shanesc/how-to-sort-and-cleanup-imports-on-save-in-vs-code-52p1 |
Contributor
Author
The main thing is that this will force everyone to do it since it will be tied to CI |
jpellizzari
approved these changes
Sep 11, 2023
Contributor
|
Cool! Is there some cli variant that we could invoke via make/yarn as a fallback for non-vscode users? |
Contributor
Author
By cli variant do you mean |
993905a to
2aabe98
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: weaveworks/weave-gitops-enterprise#3215
Took a dip into the
.eslintrcto prepare for work on unifying our configs between OSS and EE. This PR adds a rule that alphabetizes imports in ascending order. You can easily configure this as part of your formatting on save if you're finding yourself having to runnpm run lint -- --fixtoo much by settingin your settings.json