Add Artifact Metadata section to OCI Repository detail pages#4002
Merged
Add Artifact Metadata section to OCI Repository detail pages#4002
Conversation
jpellizzari
approved these changes
Sep 11, 2023
Contributor
jpellizzari
left a comment
jpellizzari
left a comment
There was a problem hiding this comment.
👍 No blockers, just nits.
| return metadataCopy; | ||
| }; | ||
|
|
||
| const MetadataSection: React.FC<{ title: string; items: [string, any][] }> = ({ |
Contributor
There was a problem hiding this comment.
Is any type really valid here? If I pass in { foo: { bar: 'baz' }}, will the component render OK?
Contributor
Author
There was a problem hiding this comment.
It was any bc we're turning some of the values into links - I can change it into string | JSX
Contributor
There was a problem hiding this comment.
For the sake of accuracy, I like string | JSX. That way the next person has an idea of what they can pass in.
Contributor
|
@joshri fyi weaveworks/weave-gitops-enterprise#3341 (comment) Maybe we should just show all annotations as key value pairs, while giving precedence to the pre-defined ones (that start with |
joshri
force-pushed
the
3341-oci-metadata
branch
from
5ae95c9 to
ab4cace
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: weaveworks/weave-gitops-enterprise#3341
Adds a new section to the Metadata component for OCI Repositories for clarity - we were previously displaying revision and source in the info list, but folks were expecting to see it in Metadata (which only recognizes our metadata.weaveworks prefix).