App page secrets error

[AlinaGoaga]

Closes #3843

What changed?
For helm releases, do not try and read secret if spec.kubeConfig has been set.

Why was this change made?
On the Applications Page, users would get several errors related to the secret not being present.
get helmrelease inventory: secrets "sh.helm.release.v1.grafana-agent-logs.v7" not found.
This is not relevant for cases in which kubeConfig is used.

[foot]

Nice clean up too!

[foot]

Lets try adding a little message to the UI too, some little admonition like..

Note
spec.Kubeconfig is set on this HelmRelease. Details about reconciled objects are not available.

[AlinaGoaga]

Hi @mmoulian, we're got an info alert in this PR. I can't seem to be able to find something similar in the designs. Would you mind having a look at the styles and let me know which colors you'd prefer / add it to Figma? Below is how it looks atm.

Thank you

[mmoulian]

Hi @AlinaGoaga! Searching through our archive files I found this solution. We did it for alerts and errors, but I'm not sure if the alert in PR is the same type or needs a distinction.

Link Figma: https://www.figma.com/file/IVHnM9iyeFWpd11evtY8ux/Weave-GitOps?type=design&node-id=19837%3A54217&mode=design&t=TuqsDZiQ4rVgsarD-1

This solution is applied in our Demo on a page like this:

Let me know if it help you!

[AlinaGoaga]

Thanks @mmoulian, yup I know these ones, we need one in blue for the info box please (light and dark)

[mmoulian]

@AlinaGoaga I made the design here. ..It is very similar to your proposal. You can see it in dark or light mode (see movie).
Things to keep in mind:
-The corners are rounded 8 px
-Texts 14 px / line height 16 px
-I added these colors to our Variable Design System (See image)

https://github.com/weaveworks/weave-gitops/assets/95616291/36d928a5-9d94-4b3e-8c4d-9c57ac8056c3
https://www.figma.com/file/IVHnM9iyeFWpd11evtY8ux/Weave-GitOps?type=design&node-id=17897%3A199195&mode=design&t=fxC0g6SpQsA2Cyie-1

Note.PR.mov

[AlinaGoaga]

Thanks @mmoulian, will open a small PR separately to adjust the style :)

[rudolfdobias]

Seems that this change caused that only HelmRelease type can have detail now as reported in this bug.