Fix Suspend button width on Source details pages with short status message#4030
Merged
Fix Suspend button width on Source details pages with short status message#4030
Conversation
opudrovs
added
bug
opudrovs
force-pushed
the
4001-fix-suspend-button-width
branch
from
a764297 to
ef41251
Compare
opudrovs
changed the title
opudrovs
force-pushed
the
4001-fix-suspend-button-width
branch
from
ef41251 to
767f319
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4001
min-width: fit-contentto theSyncActionscomponent to prevent Suspend button being to narrow on Source details pages in the status message is too short.Notes:
width: 50%specified in theSyncActionscomponent. As discussed with @joshri, this width setting was added to make the buttons play nicely with Applied Revision and Last Updated elements on Application details pages.Testing:
https://gitops.euw1.wego-gke.weave.works/helm_chart/details?clusterName=Default&name=dex-dex&namespace=flux-system
At least on my laptop's screen:
To reproduce the original issue in the main branch, just go to a Source details page and change the object status message to smth. short (HelmChart have shorter message than other sources thats why this issue was visible on HelmChart pages):
In the current branch with the fix, the Suspend button should look as expected:
You can also check that the fix does not change the layout of Application details page (the issue with Suspend button was not happening on the Application details pages, but I would not like to introduce any changes to the elements' layout with the fix) and Applied Revision and Last Updated elements look like before on wide and narrow screens: