Link clusterName in image automation details#4035
Merged
TheGostKasper merged 3 commits intomainfrom Sep 21, 2023
Merged
Conversation
opudrovs
reviewed
Sep 20, 2023
| return ( | ||
| h.visible !== false && ( | ||
| {items | ||
| .filter((h) => h.visible !== false) |
Contributor
There was a problem hiding this comment.
You can replace this line with .filter((h) => h.visible)
Contributor
There was a problem hiding this comment.
And there is another line like that in HeaderRows.test.tsx:
if (h.visible !== false) {
which can be replaced with
if (h.visible) {
Optional. but since you are working on these files anyway.
Contributor
Author
There was a problem hiding this comment.
not all the items contains visible:true so that we deal with it as a default value for items to be visible:true
for example:
{
rowkey: "Policy Name",
value: "Controller ServiceAccount Tokens Automount",
},
{
rowkey: "Application",
value: "flux-system/external-secrets",
},
{
rowkey: "Violation Time",
value: "15 minutes ago",
},
{
rowkey: "Category",
value: " weave.categories.access-control",
visible: false,
},
here we want only to filter over what's not false to save extra checks & make visible required
Contributor
There was a problem hiding this comment.
I see, thanks for the explanation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of ee 3339
What changed?
clusterNamein ImageAutomation detail pageHeaderRowsvisible items before looping over its items