Skip to content

Add text wrap to fit long term ex. progressive delivery#4038

Merged
ahussein3 merged 4 commits intomainfrom
UpdateDeliveryIcon
Sep 25, 2023
Merged

Add text wrap to fit long term ex. progressive delivery#4038
ahussein3 merged 4 commits intomainfrom
UpdateDeliveryIcon

Conversation

@ahussein3
Copy link
Copy Markdown
Contributor

@ahussein3 ahussein3 commented Sep 21, 2023

Closes #3301

What changed?

  • Add text wrap to break the long nav item into two rows.
  • Update the Delivery icon which is used by progressive delivery to be a flagger icon.

Why was this change made?

  • Add text wrap in nav items so that long term like "Progressive Delivery" would fit into two lines as it's requested here.

@joshri
Copy link
Copy Markdown
Contributor

joshri commented Sep 21, 2023

Looks good - but does this close the issue? It doesn't actually change the nav text or page title to Progressive Delivery. Totally fine to do it separately if that was the plan

@ahussein3
Copy link
Copy Markdown
Contributor Author

@joshri Yes that's only updating the icon but the text pr will be in EE repo.

@ahussein3
Copy link
Copy Markdown
Contributor Author

  • Before:
    image

  • After:
    image

@ahussein3 ahussein3 requested a review from foot September 25, 2023 09:02
@ahussein3 ahussein3 changed the title Reduce nav items padding to fit long term ex. progressive delivery Add text wrap to fit long term ex. progressive delivery Sep 25, 2023
@foot
Copy link
Copy Markdown
Contributor

foot commented Sep 25, 2023

It feels a tiny bit cramped now when selected.

Maybe we could try

  • removing the margin-bottom (~4px now)
  • giving that space to the height of the links instead (32px -> 36px)

@ahussein3
Copy link
Copy Markdown
Contributor Author

It feels a tiny bit cramped now when selected.

Maybe we could try

  • removing the margin-bottom (~4px now)
  • giving that space to the height of the links instead (32px -> 36px)

here it how it looking after giving it space without removing the margin-bottom as they will stack up if we did
image

@ahussein3 ahussein3 merged commit 99da256 into main Sep 25, 2023
@ahussein3 ahussein3 deleted the UpdateDeliveryIcon branch September 25, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants