Move header creation outside yaml view to allow for custom text#4069
Merged
Move header creation outside yaml view to allow for custom text#4069
Conversation
Contributor
|
LGTM, but some UI tests are failing. |
Contributor
Author
|
yep - missed changing the prop in the test |
opudrovs
approved these changes
Oct 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to use the DetailModal component for the PR Preview in the upcoming add source UI in EE - part of this means replacing the
kubectl getcommand from the YamlView header with the path of your potential resource, so I moved the creation of the header up a level in the component tree, and addedpathas an option in the the createYamlHeader function.