Skip to content

override default tabs min-width at (600px) media query#4071

Merged
ahussein3 merged 2 commits intomainfrom
ReduceTabsWidthToFitLargeScreen
Oct 9, 2023
Merged

override default tabs min-width at (600px) media query#4071
ahussein3 merged 2 commits intomainfrom
ReduceTabsWidthToFitLargeScreen

Conversation

@ahussein3
Copy link
Copy Markdown
Contributor

@ahussein3 ahussein3 commented Oct 9, 2023

Closes #3392

What changed?

  • update the tab min-width to be auto and update the size on larger screen size.

Why was this change made?

  • This change made to make the tabs component being usable on smaller screen size.

How did you validate the change?

  • Tested locally

@ahussein3 ahussein3 added the area/ui Issues that require front-end work label Oct 9, 2023
@ahussein3 ahussein3 self-assigned this Oct 9, 2023
@ahussein3 ahussein3 requested review from foot and jpellizzari October 9, 2023 07:53
@ahussein3
Copy link
Copy Markdown
Contributor Author

ahussein3 commented Oct 9, 2023 •
edited
Loading

Both screen shots at 1024px width view.

Before:
image

After:
image

@ahussein3 ahussein3 changed the title override default tabs min-width at media query override default tabs min-width at (600px) media query Oct 9, 2023
@ahussein3 ahussein3 merged commit 43c7d9f into main Oct 9, 2023
@ahussein3 ahussein3 deleted the ReduceTabsWidthToFitLargeScreen branch October 9, 2023 18:53
@weave-gitops-bot weave-gitops-bot mentioned this pull request Oct 11, 2023
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

@foot foot Awaiting requested review from foot

Assignees

@ahussein3 ahussein3

Labels

area/ui Issues that require front-end work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahussein3 @jpellizzari