Skip to content

fix: Only run npm publish job on weave-gitops repo#4083

Merged
yiannistri merged 1 commit intomainfrom
prevent-publish-js-on-forks
Oct 16, 2023
Merged

fix: Only run npm publish job on weave-gitops repo#4083
yiannistri merged 1 commit intomainfrom
prevent-publish-js-on-forks

Conversation

@yiannistri
Copy link
Copy Markdown
Contributor

What changed?
There's a step in our CI process that pushes an npm package to the GitHub npm registry. This step fails when executed in forks of the repo. This change attempts to only run this step for PRs within the weave-gitops repo.

Why was this change made?
To prevent CI from failing when running in forks.

Copy link
Copy Markdown
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yiannistri yiannistri merged commit 8b91b02 into main Oct 16, 2023
@yiannistri yiannistri deleted the prevent-publish-js-on-forks branch October 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants