Conversation
Merged
3 tasks
opudrovs
reviewed
Oct 18, 2023
|
|
||
| ### Profiling | ||
|
|
||
| Profiling can be useful during operation to help you to gain deeper understanding of the management cluster is behaving a runtime. |
Contributor
There was a problem hiding this comment.
of the management cluster is behaving a runtime should it be of how the management cluster is behaving a runtime?
Go,profiling - a space before the comma is missing.
Contributor
Author
There was a problem hiding this comment.
thanks, updated to make it a bit more clear.
opudrovs
reviewed
Oct 18, 2023
opudrovs
approved these changes
Oct 18, 2023
Contributor
opudrovs
left a comment
opudrovs
left a comment
There was a problem hiding this comment.
LGTM, only minor comments.
enekofb
force-pushed
the
add-profiling-docs
branch
from
cb7e119 to
dbc15a2
Compare
Merged
This was referenced Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of weaveworks/weave-gitops-enterprise#3228
What changed?
How did you validate the change?
Developed locally