refactor: refactor away from deprecated wait.Poll calls#4107
Merged
Conversation
yitsushi
force-pushed
the
3812-refactor-deprecated-wait-poll
branch
from
c4edf9d to
5c4820e
Compare
With the update, some other calls had to be updated: - `NewDiscoveryRESTMapper` expects an extra `HTTPClient` argument - `client` does not have `NewDelegatingClient` anymore, instead we can create the same resource with `client.New(...)` Resolves #3812 References: - #3812 - kubernetes-sigs/controller-runtime#2150 - https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yitsushi
force-pushed
the
3812-refactor-deprecated-wait-poll
branch
from
5c4820e to
dd73b50
Compare
…ith updated controller-runtime Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yiannistri
reviewed
Oct 31, 2023
Comment on lines
-234
to
-244
|
|
||
| // Replace k8s.io packages v0.26 to downgrade controller-runtime to v0.14.6 | ||
| replace ( | ||
| k8s.io/api => k8s.io/api v0.26.8 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.26.8 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.26.8 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.26.8 | ||
| k8s.io/client-go => k8s.io/client-go v0.26.8 | ||
|
|
||
| sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.14.6 | ||
| ) |
Co-authored-by: Yiannis Triantafyllopoulos <8741709+yiannistri@users.noreply.github.com>
yiannistri
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3812
What changed?
wait.Pollis replaced withwait.PollUntilContextTimeoutcalls.Why was this change made?
wait.Pollis deprecatedHow was this change implemented?
With the update, some other calls had to be updated:
NewDiscoveryRESTMapperexpects an extraHTTPClientargumentclientdoes not haveNewDelegatingClientanymore, instead we can create the same resource withclient.New(...)References:
wait.Pollcalls #3812How did you validate the change?
Run tests and clicked a reasonable number of pages on the UI through
tiltRelease notes
Documentation Changes
Nothing