fix: Remove GitOps Run CLI commands#4111
Merged
yiannistri merged 2 commits intomainfrom Oct 31, 2023
Merged
Conversation
yiannistri
force-pushed
the
remove-gitops-run-cli
branch
from
d83194b to
07d7673
Compare
yitsushi
reviewed
Oct 31, 2023
Comment on lines
+20
to
+23
| "github.com/weaveworks/weave-gitops/cmd/gitops/replan" | ||
| "github.com/weaveworks/weave-gitops/cmd/gitops/resume" | ||
| "github.com/weaveworks/weave-gitops/cmd/gitops/set" | ||
| "github.com/weaveworks/weave-gitops/cmd/gitops/suspend" |
Contributor
There was a problem hiding this comment.
Do we want to keep these still? As I see it removes only beta, remove, and run.
If we want to keep replan, resume, suspend, etc, do we want to delete remove?
Contributor
Author
There was a problem hiding this comment.
The reason for deleting remove is because the only command there was used to remove GitOps Run sessions. replan, resume and suspend commands are interacting with Terraform resources which is why I kept them.
yitsushi
approved these changes
Oct 31, 2023
yitsushi
approved these changes
Oct 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #weaveworks/weave-gitops-enterprise#3514
What changed?
Updated the gitops CLI to remove GitOps Run commands.
Why was this change made?
Because we are deprecating this feature.
How was this change implemented?
By deleting the Go files that included GitOps Run-related commands.
How did you validate the change?
Release notes
TBD
Documentation Changes
We have updated docs already.