Docs: Keycloak OIDC Guide#4113
Docs: Keycloak OIDC Guide#4113foot merged 5 commits intoweaveworks:mainfrom mircea-pavel-anton:docs/keycloak_oidc_guide
Conversation
|
@bigkevmcd here is the PR for the Keycloak guide we talked about! |
|
I need to look a bit more into the file structure and the actual website config as I am not familiar with docusaurus at all 😅 |
bigkevmcd
left a comment
bigkevmcd
left a comment
There was a problem hiding this comment.
This looks fantastic, I'll find out "where" to put it, but otherwise I'd be happy to accept this, thanks for the work.
makkes
left a comment
makkes
left a comment
There was a problem hiding this comment.
Thanks for this wonderful guide. I left some comments.
@bigkevmcd as to where to leave this, I think after merging in #3917 we can incorporate it either into that page or as a distinct page and link to it from the general OIDC guide.
|
@makkes I will look on the comments this weekend and fix everything up! Thanks |
|
@mirceanton can you please rebase your branch on top of |
|
@makkes done. Rebased and squashed. Though I must ask, why squash the commits on the MR instead of |
|
I replaced the Keycloak guide in the OIDC guide with a link to this new page and also moved this page to the top-level section for simplicity. Great job @mirceanton! /cc @bigkevmcd |
We shouldn't make the navigation more complex as it needs to be. The "guides" section only has 4 guides right now so it provides a better UX if we keep it flat.
The namespaced RoleBinding isn't necessary when the group is granted cluster admin access.
|
Thanks a lot, @mirceanton. This will definitely save users from a lot of headaches. 👏🏻 🎖️ |
4 participants
Addresses #4109
What changed?
Improved documentation to contain a step-by-step guide of configuring the Keycloak OIDC integration.
Why was this change made?
The documentation for the generic OIDC setup was not clear enough as to make the process seamless.
How did you validate the change?
By following the steps described in the guide 😆
Release notes
Documentation Changes
Not really, it's just docs.