Add new svg icon as CLusterDiscovery icon#4114
Merged
Conversation
foot
approved these changes
Nov 2, 2023
Contributor
foot
left a comment
foot
left a comment
There was a problem hiding this comment.
Replaced Sources w/ ClusterDiscovery and it seemed to render okay 👍
jpellizzari
approved these changes
Nov 2, 2023
Contributor
jpellizzari
left a comment
jpellizzari
left a comment
There was a problem hiding this comment.
Approving, since we have other Icons like this, but we don't get the benefit of browser caching when we inline SVG into our JS bundles.
If this were an <img /> tag, the browser would cache the image and our bundle size would be reduced.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add New Icon for new navigation item ( Cluster Discovery Icon)