Skip to content

chore: Remove GitOps Run components#4116

Merged
yiannistri merged 3 commits intomainfrom
remove-gitops-run-libs
Nov 2, 2023
Merged

chore: Remove GitOps Run components#4116
yiannistri merged 3 commits intomainfrom
remove-gitops-run-libs

Conversation

@yiannistri
Copy link
Copy Markdown
Contributor

@yiannistri yiannistri commented Nov 1, 2023

Part of #weaveworks/weave-gitops-enterprise#3514

What changed?
As part of deprecating GitOps Run, we also need to remove any components used by it.

Why was this change made?
To ensure we don't have code that is not being used.

How did you validate the change?

make
./bin/gitops --help

Release notes
TBD

Documentation Changes
Already done.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 1, 2023

Deploy Preview for gitops-io ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/gitops-io/deploys/65426f27489c3011b8c80fa7
😎 Deploy Preview https://deploy-preview-4116--gitops-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yiannistri yiannistri force-pushed the remove-gitops-run-libs branch from 974c9e3 to fb9d707 Compare November 1, 2023 16:26
@yiannistri yiannistri marked this pull request as ready for review November 1, 2023 16:34
@opudrovs
Copy link
Copy Markdown
Contributor

opudrovs commented Nov 2, 2023

It looks like pkg/run/git_exec.go can be deleted too (unless it is required for some future purposes).

@opudrovs
Copy link
Copy Markdown
Contributor

opudrovs commented Nov 2, 2023

And I see adding the following command left in enterprise, probably it's related to the whole issue:
https://github.com/weaveworks/weave-gitops-enterprise/blob/7c4384106bd568eb0d191e8849e63ca5b8097016/cmd/gitops/app/root/cmd.go#L141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants