Allow optional OIDC values in Helm chart#4119
Merged
Samra10 merged 3 commits intoweaveworks:mainfrom Nov 9, 2023
Merged
Conversation
Samra10
approved these changes
Nov 9, 2023
Contributor
|
@bcorijn Thank you for your contribution this should be out in the next release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3833
What changed?
Only the required OIDC values were able to be specified in the Helm Values. I added an optional map for optional values such as customScopes, which are required for certain OIDC providers
Why was this change made?
Improve Helm compatibility with OIDC providers such as GitLab or Azure
How was this change implemented?
Added an optional map of values, enabling future compatibility of extra values without requiring Helm changes
How did you validate the change?
Verify output of the Helm chart
Release notes
No
Documentation Changes
No