Skip to content

Add monitoring to object cleaner#4133

Merged
opudrovs merged 1 commit intomainfrom
WGE3043-add-monitoring-to-object-cleaner
Nov 17, 2023
Merged

Add monitoring to object cleaner#4133
opudrovs merged 1 commit intomainfrom
WGE3043-add-monitoring-to-object-cleaner

Conversation

@opudrovs
Copy link
Copy Markdown
Contributor

@opudrovs opudrovs commented Nov 15, 2023

Part of weaveworks/weave-gitops-enterprise#3043

  • Updated Explorer monitoring documentation to include the object cleaner metrics.

Notes:

  • Not sure if we need such a large screenshot which shows all parts of the Explorer dashboard. If not, I can restore the old screenshot.
  • Naming suggestions are welcome.

Questions:

  • Do we agree on calling the cleaner component officially everywhere Objects Cleaner or Object Cleaner?

I saw it called differently in different places. For now, I am calling it Objects Cleaner.

@opudrovs opudrovs added the documentation Improvements or additions to documentation label Nov 15, 2023
@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch 7 times, most recently from fcc6c1c to ea162ab Compare November 17, 2023 00:57
@opudrovs opudrovs marked this pull request as ready for review November 17, 2023 10:10
@opudrovs opudrovs requested a review from a team November 17, 2023 10:11
Copy link
Copy Markdown
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor suggestions

Comment thread website/docs/explorer/operations.mdx Outdated
Comment thread website/docs/explorer/operations.mdx Outdated
Comment thread website/docs/explorer/operations.mdx Outdated
Comment thread website/docs/explorer/operations.mdx Outdated
Comment thread website/docs/explorer/operations.mdx Outdated
Comment thread website/docs/explorer/imgs/explorer-query-metrics.png
@opudrovs
Copy link
Copy Markdown
Contributor Author

@enekofb neat suggestions, thanks!

@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch 6 times, most recently from aa959a7 to 56d9324 Compare November 17, 2023 19:17
…r metrics.

Update the Explorer dashboard screenshot.
@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch from e0e6caf to 82888b7 Compare November 17, 2023 19:20
@opudrovs opudrovs merged commit b9493a8 into main Nov 17, 2023
@opudrovs opudrovs deleted the WGE3043-add-monitoring-to-object-cleaner branch November 17, 2023 19:30
This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants