Skip to content

Add latest flux version for Flux discovery.#4166

Merged
bigkevmcd merged 1 commit intomainfrom
add-new-flux-version
Dec 30, 2023
Merged

Add latest flux version for Flux discovery.#4166
bigkevmcd merged 1 commit intomainfrom
add-new-flux-version

Conversation

@bigkevmcd
Copy link
Copy Markdown
Contributor

@bigkevmcd bigkevmcd commented Dec 12, 2023

Closes

What changed?
This adds the latest source-controller v1.2.2 as a marker for Flux v2.1.2.

Dependencies are updated, and code updated to reflect the updates to dependencies.

This requires upstream changes in tf-controller (because of updates to the Flux dependencies).

Why was this change made?
To support the latest version of Flux when the version isn't on the namespace.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@bigkevmcd bigkevmcd requested a review from foot December 12, 2023 13:03
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 6 times, most recently from ddbd89b to df0361c Compare December 13, 2023 08:53
Comment thread core/server/inventory.go Outdated
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 4 times, most recently from 66670cf to da9ac91 Compare December 13, 2023 14:06
Comment thread core/server/inventory.go Outdated
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 3 times, most recently from d4ccfa8 to ecc9b2a Compare December 14, 2023 10:47
Comment thread core/server/inventory.go
Comment thread core/server/inventory.go Outdated
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 2 times, most recently from 76a9930 to 9fc9cce Compare December 15, 2023 12:15
Comment thread core/server/inventory.go Outdated
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch from 9fc9cce to acd66aa Compare December 15, 2023 14:10
Comment thread core/server/inventory.go Outdated
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch 3 times, most recently from afd1cd4 to 57cdc0a Compare December 18, 2023 13:50
Copy link
Copy Markdown
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a Flux perspective, changes now look all good to me 💯

This adds the latest source-controller v1.2.2 as a marker for Flux
v2.1.2.

Dependencies are updated to allow us to pull in the latest Flux code.

And we now pull the internal Helm release storage version from the
history, rather than the latest version field.

If there's no history, we retain the old version.
@bigkevmcd bigkevmcd force-pushed the add-new-flux-version branch from e0b62c7 to 6b19c5c Compare December 30, 2023 13:16
@bigkevmcd bigkevmcd merged commit 591cc3d into main Dec 30, 2023
@bigkevmcd bigkevmcd deleted the add-new-flux-version branch December 30, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants