Helm: Add namespace to all resources#4195
Merged
casibbald merged 4 commits intoweaveworks:mainfrom Nov 14, 2024
Merged
Conversation
casibbald
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added namespace field to all resources in the helm chart.
Why was this change made?
Helm template renders resources without namespace. All resources by default are created in the default namespace.
How was this change implemented?
Nothing special, just added release.namespace key to all the manifests.
How did you validate the change?
Release notes
Worth to mention it in the changelog, but no actions are required for the most of installations.
Documentation Changes
No documentation changes.