Fix create dashboard command#4237
Closed
makkes wants to merge 1 commit intoweaveworks:mainfrom
Closed
Conversation
The code to detect an already installed dashboard was broken in 379395c. This commit fixes the `GetInstalledDashboard` function to properly detect an installed dashboard and re-enables the tests that have been commented out in that same commit. Signed-off-by: Max Jonas Werner <max@coppersoft.eu>
Member
Author
|
This has already been fixed in #4236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to detect an already installed dashboard was broken in 379395c. This commit fixes the
GetInstalledDashboardfunction to properly detect an installed dashboard and re-enables the tests that have been commented out in that same commit.