Skip to content

chore: enable nolintlint linter #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
casibbald merged 1 commit into from
Dec 31, 2024
Merged

chore: enable nolintlint linter #4331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ linters:
- ineffassign
#- lll
#- misspell
#- nolintlint
- nolintlint
#- prealloc
- staticcheck
- stylecheck
Expand Down
4 changes: 2 additions & 2 deletions core/clustersmngr/cluster/delegating_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestDelegatingCacheGet(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()

go cache.Start(ctx) //nolint:errcheck
go cache.Start(ctx)

if ok := cache.WaitForCacheSync(ctx); !ok {
g.Fail("failed syncing client cache")
Expand Down Expand Up @@ -59,7 +59,7 @@ func TestDelegatingCacheList(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()

go cache.Start(ctx) //nolint:errcheck
go cache.Start(ctx)

if ok := cache.WaitForCacheSync(ctx); !ok {
g.Fail("failed syncing client cache")
Expand Down
2 changes: 1 addition & 1 deletion pkg/run/install/apply_manifests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func NewManager(ctx context.Context, log logger.Logger, kubeClient ctrlclient.Cl
}

// apply is the equivalent of 'kubectl apply --server-side -f'.
func apply(ctx context.Context, log logger.Logger, manager ResourceManagerForApply, manifestsContent []byte) (string, error) { // nolint:unparam
func apply(ctx context.Context, log logger.Logger, manager ResourceManagerForApply, manifestsContent []byte) (string, error) { //nolint:unparam
objs, err := utils.ReadObjects(bytes.NewReader(manifestsContent))
if err != nil {
log.Failuref("Error reading Kubernetes objects from the manifests")
Expand Down