chore: remove unused useRequestState#4335
Merged
casibbald merged 2 commits intoweaveworks:mainfrom Jan 1, 2025
tenstad:rm-use-request-state
Merged
chore: remove unused useRequestState#4335casibbald merged 2 commits intoweaveworks:mainfrom tenstad:rm-use-request-state
casibbald merged 2 commits intoweaveworks:mainfrom
tenstad:rm-use-request-state
Conversation
This was referenced Jan 15, 2025
This was referenced Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Removes useRequestState
Why was this change made?
It's not in use and causes issues in React 18 #4334 (rendering
errorinreturn <div data-testid={id}>{error}</div>;, as it's not a ReactNode).We can alternatively do a small workaround instead of removing it completely:
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes