Revert "ci: init new workflow to build images (#4468)"#4473
Closed
Revert "ci: init new workflow to build images (#4468)"#4473
Conversation
This reverts commit 62b675f.
erikgb
approved these changes
Jan 9, 2025
Contributor
erikgb
left a comment
erikgb
left a comment
There was a problem hiding this comment.
But I don't think there is anything wrong with using the GitHub Action token for pushing packages to GHCR. Any remains from the Enterprise setup? We should investigate this more.
Contributor
|
This issue is fixed now, so no need to revert: https://github.com/weaveworks/weave-gitops/actions/workflows/build-image.yaml?query=branch%3Amain. Roll-forward is always better than rolling back. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4468
We Need to resubmit this with potentially a different token